Add message library generation to gui #558
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azeey
reviewed
Aug 1, 2023
CMakeLists.txt
Outdated
| #-------------------------------------- | ||
| # Find gz-plugin | ||
| gz_find_package(gz-sensors8-msgs REQUIRED) | ||
| gz_find_package(gz-sensors8 REQUIRED) |
There was a problem hiding this comment.
Oof, do we need to depend on gz-sensors8 or is this just temporary?
There was a problem hiding this comment.
Ah, no, we should not need this. Only a dependency on gz-sensors8-msgs, I believe.
| syntax = "proto3"; | ||
| package gz.msgs; | ||
| option java_package = "com.gz.msgs"; | ||
| option java_outer_classname = "AirPressureSensorProtos"; |
There was a problem hiding this comment.
hmm, I would have though this would go in gz-sensors.
There was a problem hiding this comment.
The _sensor messages are actually SDF-derived and not used by sensors, as far as I can tell.
Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
mjcarroll/message_library_generation
branch
from
da9b393
to
424bc50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.