Remove ignition

[nkoenig]

🎉 New feature

Remove ignition

Checklist

• Signed all commits for DCO
• Added tests
• Added example and/or tutorial
• Updated documentation (as needed)
• Updated migration guide (as needed)
• Consider updating Python bindings (if the library has them)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[jennuine]

I found a few more places:

• https://github.com/gazebosim/gz-gui/blob/main/tutorials/01_install.md

• gz-gui/include/gz/gui/qml/qmldir

  Lines 9 to 11 in 5bbfc63

  	# Deprecated components, remove on tock
  	IgnSnackBar 1.0 GzSnackBar.qml
  	IgnSpinBox 1.0 GzSpinBox.qml

• gz-gui/examples/plugin/gz_components/GzComponents.qml

  Lines 43 to 50 in 5bbfc63

  	// Deprecated spin box
  	IgnSpinBox {
  	minimumValue: -2
  	maximumValue: 19
  	decimals: 0
  	stepSize: 3
  	value: 5

• Are we leaving this?
  

  gz-gui/src/Application.cc

  Lines 61 to 63 in 6851f04

  	/// \brief Deprecated environment variable which holds paths to look for
  	/// plugins
  	public: std::string pluginPathEnvDeprecated = "IGN_GUI_PLUGIN_PATH";

• gz-gui/src/Plugin.cc

  Line 75 in 6851f04

  /// Accepts all QML Pane properties plus custom Igntiion GUI properties.

• gz-gui/src/plugins/marker_manager/MarkerManager.cc

  Line 356 in 5bbfc63

  std::string name = "__IGN_MARKER_VISUAL_" + ns + "_" +

[nkoenig]

5844641

I found a few more places:

• https://github.com/gazebosim/gz-gui/blob/main/tutorials/01_install.md

• gz-gui/include/gz/gui/qml/qmldir

  Lines 9 to 11 in 5bbfc63

  	# Deprecated components, remove on tock
  	IgnSnackBar 1.0 GzSnackBar.qml
  	IgnSpinBox 1.0 GzSpinBox.qml

• gz-gui/examples/plugin/gz_components/GzComponents.qml

  Lines 43 to 50 in 5bbfc63

  	// Deprecated spin box
  	IgnSpinBox {
  	minimumValue: -2
  	maximumValue: 19
  	decimals: 0
  	stepSize: 3
  	value: 5

• Are we leaving this?
  

  gz-gui/src/Application.cc

  Lines 61 to 63 in 6851f04

  	/// \brief Deprecated environment variable which holds paths to look for
  	/// plugins
  	public: std::string pluginPathEnvDeprecated = "IGN_GUI_PLUGIN_PATH";

• gz-gui/src/Plugin.cc

  Line 75 in 6851f04

  /// Accepts all QML Pane properties plus custom Igntiion GUI properties.

• gz-gui/src/plugins/marker_manager/MarkerManager.cc

  Line 356 in 5bbfc63

  std::string name = "__IGN_MARKER_VISUAL_" + ns + "_" +

Remvoed in 5844641

[mjcarroll]

I think there are still a few references to pluginPathEnvDeprecated judging by current CI

[codecov]

Codecov Report

Merging #556 (7e03bab) into main (974957f) will increase coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head 7e03bab differs from pull request most recent head 1940106. Consider uploading reports for the commit 1940106 to get more accurate results

@@            Coverage Diff             @@
##             main     #556      +/-   ##
==========================================
+ Coverage   68.05%   68.14%   +0.08%     
==========================================
  Files          38       38              
  Lines        5394     5362      -32     
==========================================
- Hits         3671     3654      -17     
+ Misses       1723     1708      -15     

Files Changed	Coverage Δ
src/Plugin.cc	83.19% <ø> (+0.86%)	⬆️
src/gz.cc	42.00% <ø> (+1.61%)	⬆️
src/Application.cc	84.50% <100.00%> (+0.46%)	⬆️
src/MainWindow.cc	95.68% <100.00%> (+0.58%)	⬆️
src/plugins/marker_manager/MarkerManager.cc	58.82% <100.00%> (ø)
src/plugins/minimal_scene/MinimalScene.cc	57.73% <100.00%> (+0.06%)	⬆️

[iche033]

I think there are still a few references to pluginPathEnvDeprecated judging by current CI

I think 5fbbcf2 should do it

[jennuine]

Thank you!