Address reviewer feedback

Signed-off-by: Addisu Z. Taddese <[email protected]>

include/gz/gui/Application.hh

@@ -98,6 +98,10 @@ namespace gz::gui
       /// \sa InitializeDialogs
       public: bool LoadConfig(const std::string &_path);
 
+      /// \brief Load window configuration from XML element.
+      /// This is the <window> element inside a gui config file.
+      /// \param[in] _window XML element that contains the window configuration
+      /// \return True if successful
       public: bool LoadWindowConfig(const tinyxml2::XMLElement &_window);
 
       /// \brief Load the configuration from the default config file.
@@ -122,6 +126,11 @@ namespace gz::gui
       /// \sa SetDefaultConfigPath
       public: std::string DefaultConfigPath();
 
+      /// \brief Given an input config path, resolve its absolute path,
+      /// potentially searching for it in locations specified by
+      /// `GZ_GUI_RESOURCE_PATH`.
+      /// \input _path Path to a config file. If the path is absolute
+      /// \return The resolved path
       public: std::string ResolveConfigFile(const std::string &_path);
 
       /// \brief Set the environment variable which defines the paths to

src/Application.cc

@@ -506,6 +506,7 @@ std::string Application::DefaultConfigPath()
   return this->dataPtr->defaultConfigPath;
 }
 
+/////////////////////////////////////////////////
 std::string Application::ResolveConfigFile(const std::string &_path)
 {
   std::string configFull = _path;
@@ -534,6 +535,11 @@ std::string Application::ResolveConfigFile(const std::string &_path)
     }
   }
 
+  if (common::isRelativePath(configFull))
+  {
+    configFull = common::absPath(configFull);
+  }
+
   return configFull;
 }