Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Bionic from future releases (Garden+) #239

Merged
merged 2 commits into from
Mar 15, 2022

Conversation

chapulina
Copy link
Contributor

Summary

ign-fuel-tools8 will be on Garden.

Test it

No Bionic builds should be triggered.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina requested a review from nkoenig as a code owner March 11, 2022 17:59
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Mar 11, 2022
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #239 (da21831) into main (3c90110) will not change coverage.
The diff coverage is n/a.

❗ Current head da21831 differs from pull request most recent head 6d0d4b5. Consider uploading reports for the commit 6d0d4b5 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #239   +/-   ##
=======================================
  Coverage   75.65%   75.65%           
=======================================
  Files          20       20           
  Lines        2748     2748           
=======================================
  Hits         2079     2079           
  Misses        669      669           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c90110...6d0d4b5. Read the comment docs.

Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Copy link
Contributor Author

This is good to go!

@scpeters
Copy link
Member

windows test failures are pre-existing on main

https://build.osrfoundation.org/view/ign-garden/job/ign_fuel-tools-ci-win/18/

@chapulina chapulina merged commit e300aa2 into main Mar 15, 2022
@chapulina chapulina deleted the chapulina/main/rm/bionic branch March 15, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants