Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ign_common windows: use gdal #624

Merged
merged 5 commits into from
Jan 21, 2022
Merged

Conversation

scpeters
Copy link
Contributor

@scpeters scpeters changed the title ign_rendering windows: use gdal ign_common windows: use gdal Jan 20, 2022
@scpeters
Copy link
Contributor Author

testing: Build Status https://build.osrfoundation.org/view/ign-garden/job/ign_common-ci-win/13/

# BEGIN SECTION: install external dependency gdal
"VCPKG_HEAD is 2021.05.12"
From https://github.com/osrf/vcpkg-ports
 * branch            master     -> FETCH_HEAD
Already up to date.
Computing installation plan...
The following packages will be rebuilt:
  * qt5-activeqt[core]:x64-windows -> 5.15.2
  * qt5-base[core]:x64-windows -> 5.15.2#8
  * qt5-declarative[core]:x64-windows -> 5.15.2
  * qt5-imageformats[core]:x64-windows -> 5.15.2
  * qt5-multimedia[core]:x64-windows -> 5.15.2
  * qt5-networkauth[core]:x64-windows -> 5.15.2
  * qt5-quickcontrols2[core]:x64-windows -> 5.15.2
  * qt5-svg[core]:x64-windows -> 5.15.2
  * qt5-tools[core]:x64-windows -> 5.15.2
  * qt5-winextras[core]:x64-windows -> 5.15.2
  * sqlite3[core,tool]:x64-windows -> 3.35.4
The following packages will be built and installed:
  * cfitsio[core]:x64-windows -> 3.49
  * expat[core]:x64-windows -> 2020-08-18
    gdal[core]:x64-windows -> 3.2.2
  * geos[core]:x64-windows -> 3.9.1
  * giflib[core]:x64-windows -> 5.1.4-6
  * hdf5[core,szip,zlib]:x64-windows -> 1.12.0#2
  * libgeotiff[core]:x64-windows -> 1.6.0#2
  * libpq[core,openssl,zlib]:x64-windows -> 12.2#16
  * netcdf-c[core]:x64-windows -> 4.7.4#2
  * proj4[core,database,tiff]:x64-windows -> 7.2.1#2
  * szip[core]:x64-windows -> 2.1.1-6
Additional packages (*) will be modified to complete this operation.
If you are sure you want to rebuild the above packages, run the command with the --recurse option
Failed with error #1.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ign-physics and ign-gazebo should also need it

@scpeters
Copy link
Contributor Author

ign-physics and ign-gazebo should also need it

I think everything that depends on ign-physics and ign-rendering will need it; so we'll have to add a bit more

do we want a .github/ci/packages.vcpkg file in each repository?

@chapulina
Copy link
Contributor

do we want a .github/ci/packages.vcpkg file in each repository?

I think it depends on when we plan to tackle

@j-rivero
Copy link
Contributor

Additional packages (*) will be modified to complete this operation.
If you are sure you want to rebuild the above packages, run the command with the --recurse option
Failed with error #1.

Looks to me that vcpkg refuses to recompile/reinstall packages without the --recurse option. Probably because some of them will be installed in a different way (more/different components). I can not see any risk on trying to add that option to the install command.

@scpeters
Copy link
Contributor Author

Additional packages (*) will be modified to complete this operation.
If you are sure you want to rebuild the above packages, run the command with the --recurse option
Failed with error #1.

Looks to me that vcpkg refuses to recompile/reinstall packages without the --recurse option. Probably because some of them will be installed in a different way (more/different components). I can not see any risk on trying to add that option to the install command.

ok, let's try it: 78d153a

@scpeters
Copy link
Contributor Author

@scpeters
Copy link
Contributor Author

ign-physics and ign-gazebo should also need it

I think everything that depends on ign-physics and ign-rendering will need it; so we'll have to add a bit more

I've added the dependency to all garden dependents of ign-physics and ign-rendering in 0bf9af5

I think this is ready for review

Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@scpeters scpeters merged commit 0767374 into master Jan 21, 2022
@scpeters scpeters deleted the ci_matching_branch/require_geospatial branch January 21, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants