Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install bash completion, move CLI scripts to non-dev package #15

Merged
merged 2 commits into from
Sep 20, 2022
Merged

Install bash completion, move CLI scripts to non-dev package #15

merged 2 commits into from
Sep 20, 2022

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Aug 31, 2022 •
edited
Loading

@azeey azeey requested a review from j-rivero August 31, 2022 21:43
@scpeters scpeters mentioned this pull request Sep 14, 2022
Open
scpeters
scpeters reviewed Sep 16, 2022
View reviewed changes
Copy link
Contributor

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the files in ubuntu/debian usually don't have version numbers, so what do you think about renaming ubuntu/debian/gz-sim7-cli.install?

@j-rivero
Copy link
Contributor

I think the files in ubuntu/debian usually don't have version numbers, so what do you think about renaming ubuntu/debian/gz-sim7-cli.install?

Fixed them in 0b655fc

@j-rivero
Copy link
Contributor

Testing Build Status

@azeey azeey merged commit ab77672 into main Sep 20, 2022
@azeey azeey deleted the azeey/bash_compl_non_dev branch September 20, 2022 18:42
@azeey
Copy link
Contributor Author

azeey commented Sep 20, 2022

I think the files in ubuntu/debian usually don't have version numbers, so what do you think about renaming ubuntu/debian/gz-sim7-cli.install?

Fixed them in 0b655fc

Thanks @j-rivero

@j-rivero
Copy link
Contributor

7.0.0~pre1-2 is out with this change Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters left review comments

@j-rivero j-rivero j-rivero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@azeey @j-rivero @scpeters