Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install bash completion, move CLI scripts to non-dev package #7

Merged
merged 2 commits into from
Dec 8, 2022

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Aug 30, 2022

@azeey
Copy link
Contributor Author

azeey commented Nov 8, 2022

@j-rivero since we don't want to create a -cli package for existing packages, I've moved the ign-launch executable to the non-dev package here. Would that be a problem?

@azeey azeey requested a review from j-rivero December 7, 2022 21:53
@j-rivero
Copy link
Contributor

j-rivero commented Dec 8, 2022

Changes looks good to me.

@j-rivero since we don't want to create a -cli package for existing packages, I've moved the ign-launch executable to the non-dev package here. Would that be a problem?

I think that this was proposed in gazebo-tooling/release-tools#529. I don't see any problem with this more than creating a divergence among the different gz packages, most of them are using -dev.

The whole context and new -cli- packages is described in gazebo-tooling/release-tools#830

@j-rivero j-rivero merged commit 7e38756 into main Dec 8, 2022
@azeey azeey deleted the azeey/bash_compl_non_dev branch February 22, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants