No err message on node found #164
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-3
added
reviewed/ok-to-test
plkokanov
requested changes
Dec 13, 2024
hacks/ops-pod
Outdated
| @@ -111,7 +111,7 @@ if [[ -n ${node_of_pod} ]]; then | |||
| else | |||
| echo "Node name provided ..." | |||
| # shellcheck disable=SC2076 | |||
There was a problem hiding this comment.
This should no-longer be necessary: https://www.shellcheck.net/wiki/SC2076
| @@ -111,7 +111,7 @@ if [[ -n ${node_of_pod} ]]; then | |||
| else | |||
| echo "Node name provided ..." | |||
| # shellcheck disable=SC2076 | |||
| if [[ $(kubectl get nodes -o jsonpath='{.items[*].metadata.name}') =~ " ${node} " ]]; then | |||
| if kubectl get nodes -o jsonpath='{.items[*].metadata.name}' | grep -q "\b${node}\b"; then | |||
| echo -e "Deploying ops pod on ${node}\n" | |||
| else | |||
| echo -e "Error: node ${node} does not exist in the cluster.\n" | |||
There was a problem hiding this comment.
Can we use this PR to also add an exit 1 after the print_usage call so that we do not try to start up a pod that will never become Ready since the node does not exist?
There was a problem hiding this comment.
Actaully, should print_usage also exit?
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
PR fixes the case where a node is found but err message is still printed in
hacks/ops-pod.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: