Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solves runtime deployment issue at the helm chart. hostNetwork was not set. #117

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

angelbarrera92
Copy link

What this PR does / why we need it:

I am testing the chart locally (using kind). And I found the deployment didn't expose the port as a host port.
This is required to let the api-server reach this pod to authenticate requests.

I guess this was forgotten as the deployment available under config/samples have it: https://github.com/gardener/oidc-webhook-authenticator/blob/master/config/samples/deployment.yaml#L90

Which issue(s) this PR fixes:
Not opened yet, i can open one if it is required.

Special notes for your reviewer:
Im writing some docs to demonstrate how to make it working on a kind (locally) k8s cluster. Let me know if you want to publish it somewhere :)

Release note:

Solves runtime deployment issue at the helm chart. `hostNetwork` was not set.

@angelbarrera92 angelbarrera92 requested a review from a team as a code owner May 16, 2023 16:57
@CLAassistant
Copy link

CLAassistant commented May 16, 2023

CLA assistant check
All committers have signed the CLA.

@gardener-robot
Copy link

@angelbarrera92 Thank you for your contribution.

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels May 16, 2023
@gardener-robot-ci-3
Copy link
Contributor

Thank you @angelbarrera92 for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

@angelbarrera92 angelbarrera92 changed the title Host network deployment Solves runtime deployment issue at the helm chart. hostNetwork was not set. May 16, 2023
@dimityrmirchev
Copy link
Member

@angelbarrera92 thanks for opening this PR, however sharing the host network is something that we do not want for a productive scenario. I opened a PR that will allow setting the clusterIP through the helm charts. This will allow the kube-apiserver to directly call the service via its IP if that is required, i.e. OWA is deployed in the same k8s cluster and the kube-apiserver cannot use in-cluster dns.

@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Jan 25, 2024
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Nobody worked on this for 12 months (final aging stage) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants