Make cloud instance that is connected to configurable #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot
added
the
size/s
gardener-robot-ci-1
added
needs/ok-to-test
kon-angelo
approved these changes
May 23, 2024
|
|
||
| cloudConfigurationName := spec.CloudConfiguration.Name | ||
| switch { | ||
| case strings.EqualFold(cloudConfigurationName, "AzurePublic"): |
There was a problem hiding this comment.
Please create some Consts for the expected strings
| switch { | ||
| case strings.EqualFold(cloudConfigurationName, "AzurePublic"): | ||
| return cloud.AzurePublic, nil | ||
| case strings.EqualFold(cloudConfigurationName, "AzureGovernment"): |
There was a problem hiding this comment.
Also maybe its a good idea to have validation for the expected values, before we try to create the client
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
kon-angelo
reviewed
May 24, 2024
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot
added
size/m
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
|
/hold I think @AndreasBurger wanted to make an update right ? or is it ready to review |
gardener-robot
added
the
reviewed/do-not-merge
gardener-robot-ci-1
added
reviewed/ok-to-test
AndreasBurger
force-pushed
the
cloud-instance
branch
from
731c1a8 to
468cca2
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
AndreasBurger
force-pushed
the
cloud-instance
branch
from
468cca2 to
1e5c473
Compare
AndreasBurger
force-pushed
the
cloud-instance
branch
from
3c43287 to
1e0b5c4
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
|
I have reverted the latest change and this PR now only uses |
- add consts for known good Azure cloud names - add validation of CloudConfig
AndreasBurger
force-pushed
the
cloud-instance
branch
from
1e0b5c4 to
b8ea270
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
gardener-robot-ci-1
added
reviewed/ok-to-test
gardener-robot-ci-2
added
reviewed/ok-to-test
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
rishabh-11
added
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With this PR the cloud instance to connect to (e.g. Azure Gov Cloud, Azure Public Cloud) can be configured as part of the provider spec.
Which issue(s) this PR fixes:
This PR is a requirement to fulfill gardener/gardener-extension-provider-azure#890
Release note: