fixes the issue where the mutation log does not get printed the first… #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
gardener-robot
added
the
size/xs
|
I tested this PR on a local-setup and it still doesn't show the logs for the first change on the STS. Only subsequent changes are logged. |
gardener-robot
added
the
lifecycle/stale
gardener-robot
added
lifecycle/rotten
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As part of #59 we added logic to take a cartesian product of NSRs. Along with that change we also added an ability to compute the delta change and print it to the logs for better diagnostics. However there was a gap left where the first time a change is done to a k8s resource (e.g. sts) where there are no existing node affinity policies defined and kupid injects the policies as defined in the clusterpodschedulingpolicies then it does not print that mutation in the logs.
Which issue(s) this PR fixes:
Fixes #60
Special notes for your reviewer:
Release note: