-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[operator] Manage Gardener Dashboard #9583
Conversation
Skipping CI for Draft Pull Request. |
1ea3c7d
to
74c1c3f
Compare
/cc @ScheererJ |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
- | Generic High Entropy Secret | 85e8f76 | pkg/component/gardener/dashboard/dashboard_test.go | View secret | |
- | Generic High Entropy Secret | 02f5a1d | pkg/component/gardener/dashboard/dashboard_test.go | View secret | |
- | Generic High Entropy Secret | 85e8f76 | pkg/component/gardener/dashboard/dashboard_test.go | View secret | |
- | Generic High Entropy Secret | 02f5a1d | pkg/component/gardener/dashboard/dashboard_test.go | View secret | |
- | Generic High Entropy Secret | 85e8f76 | pkg/component/gardener/dashboard/dashboard_test.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
/assign |
…eus scrape config Now that we have a label on `Seed`s to identify whether they are reachable from the garden cluster, we can make use of it and exclude the targets of unreachable seeds.
similar to frontend config Offline PR feedback/discussion
when no webhook is configured/configurable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm 🥳
LGTM label has been added. Git tree hash: 56729f9386b2f20a1d512d04e1e139f8243ef728
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petersutter, rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
How to categorize this PR?
/area usability
/kind enhancement
What this PR does / why we need it:
With this PR,
gardener-operator
manages the Gardener Dashboard.Special notes for your reviewer:
/cc @petersutter @grolu @holgerkoser
Note
You can test it locally by running
make kind-operator-up operator-up
and thenkubectl apply -f example/operator/20-garden.yaml
.Release note:
`gardener-operator` is now managing the Gardener Dashboard when `.spec.virtualCluster.gardener.gardenerDashboard` is set in the `Garden` resource. Read more about it [here](https://github.com/gardener/gardener/tree/master/docs/concepts/operator.md#dashboard)