Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[operator] Manage Gardener Dashboard #9583

Merged
merged 28 commits into from
Apr 22, 2024

Conversation

rfranzke
Copy link
Member

@rfranzke rfranzke commented Apr 12, 2024

How to categorize this PR?

/area usability
/kind enhancement

What this PR does / why we need it:
With this PR, gardener-operator manages the Gardener Dashboard.

Special notes for your reviewer:
/cc @petersutter @grolu @holgerkoser

Note

You can test it locally by running make kind-operator-up operator-up and then kubectl apply -f example/operator/20-garden.yaml.

Release note:

`gardener-operator` is now managing the Gardener Dashboard when `.spec.virtualCluster.gardener.gardenerDashboard` is set in the `Garden` resource. Read more about it [here](https://github.com/gardener/gardener/tree/master/docs/concepts/operator.md#dashboard)

@gardener-prow gardener-prow bot requested a review from grolu April 12, 2024 17:50
Copy link
Contributor

gardener-prow bot commented Apr 12, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/usability Usability related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 12, 2024
@rfranzke rfranzke force-pushed the gop/dashboard branch 4 times, most recently from 1ea3c7d to 74c1c3f Compare April 16, 2024 12:40
@gardener-prow gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 16, 2024
@rfranzke rfranzke marked this pull request as ready for review April 16, 2024 16:04
@gardener-prow gardener-prow bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 16, 2024
@rfranzke
Copy link
Member Author

/cc @ScheererJ

@gardener-prow gardener-prow bot requested a review from ScheererJ April 16, 2024 16:05
Copy link

gitguardian bot commented Apr 16, 2024

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- Generic High Entropy Secret 85e8f76 pkg/component/gardener/dashboard/dashboard_test.go View secret
- Generic High Entropy Secret 02f5a1d pkg/component/gardener/dashboard/dashboard_test.go View secret
- Generic High Entropy Secret 85e8f76 pkg/component/gardener/dashboard/dashboard_test.go View secret
- Generic High Entropy Secret 02f5a1d pkg/component/gardener/dashboard/dashboard_test.go View secret
- Generic High Entropy Secret 85e8f76 pkg/component/gardener/dashboard/dashboard_test.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@ScheererJ
Copy link
Member

/assign

example/operator/20-garden.yaml Outdated Show resolved Hide resolved
pkg/component/gardener/dashboard/configmaps.go Outdated Show resolved Hide resolved
Copy link
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm 🥳

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2024
Copy link
Contributor

gardener-prow bot commented Apr 22, 2024

LGTM label has been added.

Git tree hash: 56729f9386b2f20a1d512d04e1e139f8243ef728

@rfranzke
Copy link
Member Author

/approve

Copy link
Contributor

gardener-prow bot commented Apr 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petersutter, rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2024
@gardener-prow gardener-prow bot merged commit ca26676 into gardener:master Apr 22, 2024
17 checks passed
@rfranzke rfranzke deleted the gop/dashboard branch April 22, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/usability Usability related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants