[node-agent] Perform hosts probing on RegistryConfig.Hosts change
#11008
Conversation
gardener-prow
bot
added
area/robustness
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
cla: no
|
/assign |
|
@dimitar-kostadinov: The following tests failed, say
Full PR test history. Your PR dashboard. Command help for this repository. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| @@ -315,3 +320,16 @@ func computeContainerdRegistryDiffs(newRegistries, oldRegistries []extensionsv1a | |||
|
|
|||
| return r | |||
| } | |||
|
|
|||
| func suppressHostsProbing(newRegistries, oldRegistries []extensionsv1alpha1.RegistryConfig) { | |||
| for i := 0; i < len(newRegistries); i++ { | |||
There was a problem hiding this comment.
| for i := 0; i < len(newRegistries); i++ { | |
| for i := range newRegistries { |
How to categorize this PR?
/area robustness
/kind enhancement
What this PR does / why we need it:
There are cases where
RegistryConfig.Hostsis changed, e.g.CACertsis added or rotated, the mirrorURLis updated, etc. Is such cases the hosts probing should be performed to ensure that new configuration is valid.Which issue(s) this PR fixes:
Part of gardener-extension-registry-cache/issues/290
Special notes for your reviewer:
N/A
Release note: