Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure record for DNSEntries are left untouched during migration #408

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Ensure record for DNSEntries are left untouched during migration #408

wants to merge 1 commit into from

Conversation

MartinWeindel
Copy link
Member

How to categorize this PR?

/area control-plane-migration
/kind bug

What this PR does / why we need it:
Depending on timing of concurrent reconciliations, the DNS records have been deleted temporarily during control plane migration. The migration step is now secured by setting an ignore annotation to the DNSEntries. The restore step is secured by ensuring that all entries have been reconciled and therefore are known before the DNSOwner is activated and a zone reconciliation is triggered.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
Relies on

Release note:

Ensure record for DNSEntries are left untouched during migration.

@gardener-robot gardener-robot added area/control-plane-migration Control plane migration related kind/bug Bug needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Dec 13, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 13, 2024
@MartinWeindel
Copy link
Member Author

/hold requires new release of external-dns-management containing above mentioned PRs.

@gardener-robot gardener-robot added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Dec 13, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 13, 2024
@MartinWeindel MartinWeindel mentioned this pull request Dec 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/control-plane-migration Control plane migration related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MartinWeindel @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot