Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skaffold: Clean up no longer needed custom tagPolicy #370

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented Mar 5, 2025

How to categorize this PR?

/area dev-productivity
/kind cleanup

What this PR does / why we need it:
See gardener/gardener-extension-shoot-rsyslog-relp#242 (review)

With #278, we introduced a custom tagPolicy.

After #357, we no longer need it as we no longer make use of the SKAFFOLD_IMAGE env var.

Which issue(s) this PR fixes:
Follow-up after #357

Special notes for your reviewer:
N/A

Release note:

NONE

@gardener-prow gardener-prow bot added area/dev-productivity Developer productivity related (how to improve development) kind/cleanup Something that is not needed anymore and can be cleaned up labels Mar 5, 2025
Copy link
Contributor

gardener-prow bot commented Mar 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ialidzhikov. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 5, 2025
Copy link

@plkokanov plkokanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2025
Copy link
Contributor

gardener-prow bot commented Mar 6, 2025

LGTM label has been added.

Git tree hash: c90c24fefa406fb0d6a8cd19a0b943462156eed4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dev-productivity Developer productivity related (how to improve development) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/cleanup Something that is not needed anymore and can be cleaned up lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants