-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overwrite registry image ENTRYPOINT to avoid panic
when scheduler-state.json
file is corrupted.
#292
Overwrite registry image ENTRYPOINT to avoid panic
when scheduler-state.json
file is corrupted.
#292
Conversation
Known flake: #290 /test pull-gardener-extension-registry-cache-e2e-kind /test pull-gardener-extension-registry-cache-unit |
/assign |
/hold |
panic
when scheduler-state.json
file is corrupted.panic
when scheduler-state.json
file is corrupted.
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: a32d790a8fcfaa7e359d572635d9114af3b40b87
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ialidzhikov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
How to categorize this PR?
/area robustness
/kind enhancement
What this PR does / why we need it:
Implements mitigation for distribution/distribution#4478.
The registry-cache container is extended with command that checks
scheduler-state.json
and if it is corrupted, to clean up the persistent volume mounted under/var/lib/registry
.The command that perform the check and cleanup is:
Which issue(s) this PR fixes:
Fixes #291
Special notes for your reviewer:
Steps to reproduce the issue:
k -n kube-system exec -it registry-docker-io-0 -- sh
, and corrupt the file:k -n shoot--local--local exec -it machine-shoot--local--local-local-6cffc-lxvbn -- bash
, and kill the registry container:status.containerStatuses[0].containerID
.Release note: