Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CA rotation TM test #285

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dimitar-kostadinov
Copy link
Contributor

@dimitar-kostadinov dimitar-kostadinov commented Nov 12, 2024

How to categorize this PR?

/area testing
/kind test

What this PR does / why we need it:
Add certificate rotation Test Machinery test to verify that registry cache is working after the Prepared and Completed rotation phases.

Which issue(s) this PR fixes:
Part of #203

Special notes for your reviewer:
The PR will be draft until #245 is merged.

Release note:

A new TM test to verify that registry cache is working after CA rotation is now added.

Copy link
Contributor

gardener-prow bot commented Nov 12, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/testing Testing related kind/test Test do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 12, 2024
@gardener-prow gardener-prow bot requested a review from ialidzhikov November 12, 2024 14:17
@gardener-prow gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 25, 2024
@gardener-ci-robot
Copy link

The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

  • After 15d of inactivity, lifecycle/stale is applied
  • After 15d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 7d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Mark this PR as rotten with /lifecycle rotten
  • Close this PR with /close

/lifecycle stale

@gardener-prow gardener-prow bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 10, 2024
@dimitar-kostadinov
Copy link
Contributor Author

/remove-lifecycle stale

@gardener-prow gardener-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 11, 2024
@dimitar-kostadinov dimitar-kostadinov force-pushed the ehn/add_cert_rotation_tm_test branch from 62fe396 to 0770416 Compare December 13, 2024 07:30
@gardener-prow gardener-prow bot removed the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Dec 13, 2024
Copy link
Contributor

gardener-prow bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from dimitar-kostadinov. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 13, 2024
@dimitar-kostadinov dimitar-kostadinov marked this pull request as ready for review December 13, 2024 07:31
@gardener-prow gardener-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 13, 2024
@dimitar-kostadinov dimitar-kostadinov force-pushed the ehn/add_cert_rotation_tm_test branch from 0770416 to 25cead1 Compare December 13, 2024 07:48
@ialidzhikov
Copy link
Member

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Testing related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/test Test size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants