Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable gosec for static application security testing #272

Merged
merged 5 commits into from
Nov 15, 2024

Conversation

Kostov6
Copy link
Contributor

@Kostov6 Kostov6 commented Oct 30, 2024

How to categorize this PR?

/area compliance
/kind enhancement

What this PR does / why we need it:
This PR enables gosec following gardener/gardener-extension-shoot-rsyslog-relp#189

Which issue(s) this PR fixes:
Fixes #269

Special notes for your reviewer:

Release note:

`gosec` is made available for SAST(static application security testing). It can be run with `make sast` or `make sast-report`, but is also incorporated in the `verify` and `verify-extended` makefile targets. 

@gardener-prow gardener-prow bot added the area/compliance Compliance related label Oct 30, 2024
@gardener-prow gardener-prow bot added the kind/enhancement Enhancement, improvement, extension label Oct 30, 2024
@gardener-prow gardener-prow bot requested a review from ialidzhikov October 30, 2024 14:41
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 30, 2024
.gitignore Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
@Kostov6
Copy link
Contributor Author

Kostov6 commented Nov 14, 2024

/retest

@ialidzhikov
Copy link
Member

#287 is merged. Can you rebase the PR to adopt the changes from gardener/gardener#10766?

Makefile Outdated Show resolved Hide resolved
@ialidzhikov
Copy link
Member

I rebased the PR and addressed the small comment.

Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2024
Copy link
Contributor

gardener-prow bot commented Nov 15, 2024

LGTM label has been added.

Git tree hash: 444bd142cf91d4d3bb38670a1a81e963419d1389

Copy link
Contributor

gardener-prow bot commented Nov 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2024
@ialidzhikov
Copy link
Member

Known flake: #290

/test pull-gardener-extension-registry-cache-e2e-kind

@gardener-prow gardener-prow bot merged commit c3093b6 into gardener:main Nov 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/compliance Compliance related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce gosec for Static Application Security Testing (SAST)
2 participants