Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Deployment in Garden Runtime Cluster #994

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix Deployment in Garden Runtime Cluster #994

wants to merge 3 commits into from

Conversation

timuthy
Copy link
Member

@timuthy timuthy commented Mar 3, 2025

How to categorize this PR?

/area delivery
/kind bug
/platform openstack

What this PR does / why we need it:
This PR mainly fixes an issue that occurred when deploying the extension as an Gardener Operator extension to the garden runtime cluster.
Because of the seed default values, it unconditionally deployed the gardener.cloud-fast storage class which is not only unexpected if the runtime garden is no OpenStack cluster, but caused race conditions with other provider extensions in the very same cluster (see commit descriptions).

Special notes for your reviewer:
/cc @MartinWeindel

Release note:

Fixed an issue that caused deployment issues with the `gardener.cloud-fast` storage class when the extension was deployed by `gardener-operator` in the garden runtime cluster. The deployment of this `StorageClass` object is now only done for OpenStack seeds.

timuthy added 3 commits March 3, 2025 14:52
@timuthy
Fix StorageClass deployment
1f723e5 
The `StorageClass` must not be considered if deployed
by the `gardener-operator` to the runtime cluster.
Otherwise different extensions fight against creating
the same resource in the cluster.
@timuthy
Drop default values for seed and runtime cluster
abc2648 
The default values shouldn't anticipate if the extension
is deployed to a seed or garden runtime cluster.
Dropping the default values makes this chart handling
less error-prone.
@timuthy
[make generate]
cd58ac8
@timuthy timuthy requested review from a team as code owners March 3, 2025 14:05
@gardener-robot gardener-robot added area/delivery Delivery related kind/bug Bug platform/openstack OpenStack platform/infrastructure needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Mar 3, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/delivery Delivery related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review platform/openstack OpenStack platform/infrastructure size/s Size of pull request is small (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timuthy @gardener-robot-ci-1 @gardener-robot