Update gophercloud client to v2 #951
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
|
/test |
|
Testrun: e2e-cxfk4 +---------------------+-----------------------------+--------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+-----------------------------+--------+----------+ | infrastructure-test | infrastructure-test | Failed | 8m15s | | infrastructure-test | infrastructure-test-flow | Failed | 8m15s | | infrastructure-test | infrastructure-test-migrate | Failed | 8m15s | | infrastructure-test | infrastructure-test-recover | Failed | 8m14s | | bastion-test | bastion-test | Failed | 8m11s | +---------------------+-----------------------------+--------+----------+ |
|
@hebelsan You need rebase this pull request with latest master branch. Please check. |
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
gardener-robot-ci-1
added
reviewed/ok-to-test
hebelsan
force-pushed
the
feature/os-clientv2
branch
from
11fa368 to
339ce0d
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
|
/test |
|
Testrun: e2e-c7n5l +---------------------+-----------------------------+--------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+-----------------------------+--------+----------+ | infrastructure-test | infrastructure-test | Failed | 10m57s | | infrastructure-test | infrastructure-test-flow | Failed | 10m57s | | infrastructure-test | infrastructure-test-migrate | Failed | 10m56s | | infrastructure-test | infrastructure-test-recover | Failed | 10m57s | | bastion-test | bastion-test | Failed | 10m51s | +---------------------+-----------------------------+--------+----------+ |
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
|
the infra test work with basic credentials, but something is still missing to make the client working with app credentials (what the tm is using). |
Bobi-Wan
reviewed
Jan 30, 2025
pkg/openstack/client/client.go
Outdated
| provider.HTTPClient = *opts.HTTPClient | ||
|
|
||
| err = openstack.Authenticate(provider, *authOpts) | ||
| err = openstack.Authenticate(ctx, provider, authOpts) |
There was a problem hiding this comment.
FYI openstack.Authenticate() is called in config.NewProviderClient() as well.
I managed to get a working client without the extra Authenticate for my usecase. Though I didn't explicitly set TLSConfig, HTTPClient like you are.
hebelsan
force-pushed
the
feature/os-clientv2
branch
from
fc0bf80 to
26e652c
Compare
gardener-robot-ci-1
added
reviewed/ok-to-test
|
/test |
|
Testrun: e2e-q4rhj +---------------------+-----------------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+-----------------------------+-----------+----------+ | infrastructure-test | infrastructure-test-flow | Succeeded | 12m52s | | infrastructure-test | infrastructure-test-migrate | Failed | 9m43s | | infrastructure-test | infrastructure-test-recover | Failed | 9m43s | | bastion-test | bastion-test | Succeeded | 11m35s | | infrastructure-test | infrastructure-test | Succeeded | 12m42s | +---------------------+-----------------------------+-----------+----------+ |
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
|
/test |
|
Testrun: e2e-vk8pl +---------------------+-----------------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+-----------------------------+-----------+----------+ | infrastructure-test | infrastructure-test | Succeeded | 13m51s | | infrastructure-test | infrastructure-test-flow | Succeeded | 14m51s | | infrastructure-test | infrastructure-test-migrate | Succeeded | 12m47s | | infrastructure-test | infrastructure-test-recover | Succeeded | 15m12s | | bastion-test | bastion-test | Succeeded | 11m20s | +---------------------+-----------------------------+-----------+----------+ |
gardener-robot-ci-2
added
reviewed/ok-to-test
|
/test |
|
Testrun: e2e-rbpl8 +---------------------+-----------------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+-----------------------------+-----------+----------+ | infrastructure-test | infrastructure-test-migrate | Succeeded | 11m18s | | infrastructure-test | infrastructure-test-recover | Succeeded | 14m30s | | bastion-test | bastion-test | Succeeded | 10m50s | | infrastructure-test | infrastructure-test | Succeeded | 12m59s | | infrastructure-test | infrastructure-test-flow | Succeeded | 11m57s | +---------------------+-----------------------------+-----------+----------+ |
kon-angelo
reviewed
Mar 5, 2025
Comment on lines
+369
to
+373
| if fip.Status != "ACTIVE" || instance.Status != "ACTIVE" { | ||
| return fmt.Errorf("instance or floating ip address not ready yet") | ||
| } | ||
|
|
||
| return networkClient.UpdateFIPWithPort(ctx, floatingIP.ID, instancePort.ID) |
There was a problem hiding this comment.
I am not sure I understand this part. You already associate the fip if it's not already. Why do you make a second update call ?
| return nil | ||
| } | ||
|
|
||
| if fip.Status != "ACTIVE" || instance.Status != "ACTIVE" { |
There was a problem hiding this comment.
Maybe something to doublecheck, but I believe the FIP should already be active upon successful creation, and well, likewise for the instance. Is assigning the IP to the instance actually changing the instance status or the FIP status ? I would also argue that if not then there could be a wait introduced but not in this place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area quality
/kind enhancement
/platform openstack
What this PR does / why we need it:
This PR updates the gophercloud client to v2.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: