configure HA webhook according to replicas in the helm chart #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/control-plane
gardener-robot-ci-2
added
reviewed/ok-to-test
|
@kon-angelo You need rebase this pull request with latest master branch. Please check. |
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
kon-angelo
force-pushed
the
operator-replicas
branch
from
252ec35 to
ae1d0e6
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-1
added
the
reviewed/ok-to-test
MartinWeindel
requested changes
Dec 4, 2024
Comment on lines
+10
to
13
| high-availability-config.resources.gardener.cloud/replicas: {{ .Values.replicaCount }} | ||
| labels: | ||
| {{ include "labels" . | indent 4 }} | ||
| high-availability-config.resources.gardener.cloud/type: server |
There was a problem hiding this comment.
If you look into the code of the resourcemanager webhook, you see that it would overwrite the value calculated by the presence of the label high-availability-config.resources.gardener.cloud/type: server. Instead of 2, we would have 3 according to the current values we are using in the ControllerDeployment
Instead I suggest to use the controller settings in this case.
See: https://github.com/gardener/gardener/blob/145d6c7a55b928c9c9df7049ccb340f777d53803/pkg/utils/kubernetes/highavailability_test.go#L30
Suggested change
| high-availability-config.resources.gardener.cloud/replicas: {{ .Values.replicaCount }} | |
| labels: | |
| {{ include "labels" . | indent 4 }} | |
| high-availability-config.resources.gardener.cloud/type: server | |
| {{- if eq Values.replicaCount 1 }} | |
| high-availability-config.resources.gardener.cloud/failure-tolerance-type: "" | |
| {{- end }} | |
| labels: | |
| {{ include "labels" . | indent 4 }} | |
| {{- if ne Values.replicaCount 1 }} | |
| high-availability-config.resources.gardener.cloud/type: server | |
| {{- else }} | |
| high-availability-config.resources.gardener.cloud/type: controller | |
| {{- end }} |
There was a problem hiding this comment.
As discussed off-line, this alternative relies on some detailed behaviour of the HA webhook, which makes it hard to understand.
Maybe an boolean flag to set the annotation high-availability-config.resources.gardener.cloud/replicas: "1" is a better solution for the moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind enhancement
/platform openstack
What this PR does / why we need it:
Allows you to run the extension with a single replica. For 2+ replicas it should be no-op.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: