Add support for deployments in existing subnet #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
kind/api-change
|
@kon-angelo Command "/InviteCommand" failed with "Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the gardener/gardener-extension-provider-openstack repository.". Additional Information |
gardener-robot
added
area/control-plane
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
kon-angelo
force-pushed
the
existing-subnet
branch
from
4a5de3f to
79d4de6
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
kon-angelo
force-pushed
the
existing-subnet
branch
from
79d4de6 to
a111f7b
Compare
gardener-robot-ci-3
added
reviewed/ok-to-test
kon-angelo
added
the
area/ipcei
|
@kon-angelo You need rebase this pull request with latest master branch. Please check. |
kon-angelo
force-pushed
the
existing-subnet
branch
from
a111f7b to
e2ece8a
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
|
/test |
|
Testrun: e2e-s8djr +---------------------+-----------------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+-----------------------------+-----------+----------+ | bastion-test | bastion-test | Succeeded | 5m2s | | infrastructure-test | infrastructure-test-flow | Succeeded | 7m46s | | infrastructure-test | infrastructure-test-migrate | Succeeded | 8m1s | | infrastructure-test | infrastructure-test-recover | Failed | 9m38s | | infrastructure-test | infrastructure-test | Omitted | 0s | +---------------------+-----------------------------+-----------+----------+ |
kon-angelo
force-pushed
the
existing-subnet
branch
from
2964cff to
ac352e5
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
Co-authored-by: Kai Kummerer <[email protected]>
kon-angelo
force-pushed
the
existing-subnet
branch
from
81d75bb to
ab61029
Compare
|
/test |
|
Testrun: e2e-ldvdn +---------------------+-----------------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+-----------------------------+-----------+----------+ | infrastructure-test | infrastructure-test-flow | Succeeded | 8m3s | | infrastructure-test | infrastructure-test-migrate | Succeeded | 7m36s | | infrastructure-test | infrastructure-test-recover | Succeeded | 8m0s | | bastion-test | bastion-test | Succeeded | 5m9s | | infrastructure-test | infrastructure-test | Succeeded | 7m37s | +---------------------+-----------------------------+-----------+----------+ |
gardener-robot
added
needs/review
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
hebelsan
requested changes
Oct 21, 2024
| return fctx.ensureNewSubnet(ctx) | ||
| } | ||
|
|
||
| func (fctx *FlowContext) ensureConfiguredSubnet(_ context.Context) error { |
There was a problem hiding this comment.
I'd remove the context param if we don't use it.
Actually, I'd pass the subnetID as string param instead of the context.
This would make it easier to spot that it's checked for nil.
| @@ -995,7 +990,6 @@ func (vp *valuesProvider) addCSIManilaValues( | |||
| values["openstack"] = map[string]interface{}{ | |||
| "availabilityZones": vp.getAllWorkerPoolsZones(cluster), | |||
| "shareNetworkID": shareNetworkID, | |||
| "shareClient": infrastructure.WorkersCIDR(infraConfig), | |||
There was a problem hiding this comment.
How can the "shareClient" be set if we remove it from here?
There was a problem hiding this comment.
We don't set it basically. The shareClient constricts who can access the share, for which at the moment we have no strict need to do, it even restrict customer use cases. The template doesn't necessarily need to change, we just choose not to configure this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind enhancement
/platform openstack
What this PR does / why we need it:
/invite @Kumm-Kai
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: