Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(encryption): Make cilium encryption configuration manageable via NetworkConfig #513

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Meecr0b
Copy link

@Meecr0b Meecr0b commented Feb 28, 2025

How to categorize this PR?
/area networking
/kind enhancement

What this PR does / why we need it:
Ciliums encryption configuration is already part of the internal config helm chart, but is not configurable via NetworkConfig.

Release note:

feature user
enable cilium encryption configuration via NetworkConfig

@Meecr0b Meecr0b requested review from a team as code owners February 28, 2025 22:52
@CLAassistant
Copy link

CLAassistant commented Feb 28, 2025

CLA assistant check
All committers have signed the CLA.

@gardener-robot gardener-robot added the needs/review Needs review label Feb 28, 2025
@gardener-prow gardener-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 28, 2025
Copy link

gardener-prow bot commented Feb 28, 2025

Hi @Meecr0b. Thanks for your PR.

I'm waiting for a gardener member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gardener-robot gardener-robot added kind/api-change API change with impact on API users needs/second-opinion Needs second review by someone else area/networking Networking related kind/enhancement Enhancement, improvement, extension labels Feb 28, 2025
@gardener-robot
Copy link

@Meecr0b Thank you for your contribution.

@gardener-robot gardener-robot added the size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) label Feb 28, 2025
@Meecr0b Meecr0b changed the title feat(encryption): Allow ciliums encryption configuration feat(encryption): Make cilium encryption configuration manageable via NetworkConfig Feb 28, 2025
@gardener-robot-ci-1
Copy link
Contributor

Thank you @Meecr0b for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking Networking related kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension needs/review Needs review needs/second-opinion Needs second review by someone else needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants