Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable-bpf-masquerade when snat values are not enabled #350

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hown3d
Copy link

@hown3d hown3d commented Jun 20, 2024

How to categorize this PR?

/area networking
/kind TODO

What this PR does / why we need it:

Enable bpf-masquerading on direct routing if SNAT masquerades are not enabled.
For more information see the issue.

Which issue(s) this PR fixes:
Fixes #349

Special notes for your reviewer:

Release note:

Use BPF masquerading and therefore BPF host routing in Cilium when using direct routing.

@hown3d hown3d requested review from a team as code owners June 20, 2024 08:38
@gardener-robot gardener-robot added the area/networking Networking related label Jun 20, 2024
@gardener-robot
Copy link

@hown3d Label kind/todo does not exist.

Copy link

gardener-prow bot commented Jun 20, 2024

Hi @hown3d. Thanks for your PR.

I'm waiting for a gardener member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gardener-prow gardener-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 20, 2024
@gardener-robot
Copy link

@hown3d Thank you for your contribution.

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jun 20, 2024
@gardener-robot-ci-1
Copy link
Contributor

Thank you @hown3d for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

@axel7born
Copy link
Contributor

/ok-to-test

@gardener-prow gardener-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 20, 2024
@hown3d
Copy link
Author

hown3d commented Jul 23, 2024

/test pull-extension-networking-cilium-e2e-kind

@axel7born
Copy link
Contributor

In tests I see an issue with this change together with the apiserver-proxy.
apiserver-proxy adds aa additional ip address the service addres of the kube-apiserver to the loopback interface on each node. The endpoint for the kubernetes service has this address, so the traffic to kubernetes.cluster.local is send to the loopback device, where an envoy proxy is listening and sending the traffic via proxy-protocol to the see.
With this change this isn't working anymore. In a tcpdump I can see, that source NAT is happening and the packets are send to the default device for outgoing traffic.
I agree, that it would be nice to have bpf masquerading. However, right now, I have no easy fix for the broken apiserver-proxy connection.

@hown3d hown3d force-pushed the snat-bpf-masquarade branch from 50a1e9b to 8e35b32 Compare September 25, 2024 13:39
Copy link

gardener-prow bot commented Oct 31, 2024

@hown3d: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gardener-extension-networking-cilium-check-renovate-config 8e35b32 link true /test pull-gardener-extension-networking-cilium-check-renovate-config

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking Networking related needs/review Needs review ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable bpf-masquerading on direct routing
4 participants