Drop support for metadata records #403
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-2
added
the
reviewed/ok-to-test
…ies; cleanup of meta data records
gardener-robot-ci-3
added
needs/ok-to-test
MartinWeindel
force-pushed
the
enh/drop-dns-owner2
branch
from
8546eab to
1d937c0
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
marc1404
changed the title
marc1404
reviewed
Dec 10, 2024
| Options *FactoryOptions | ||
| Factory DNSHandlerFactory | ||
| RemoteAccessConfig *embed.RemoteAccessServerConfig | ||
| MaxMetadataRecordDeletionsPerReconciliation int |
There was a problem hiding this comment.
Due to the indentation and in comparison to the otherwise relatively brief option names it reminded me of:
😛
There was a problem hiding this comment.
Well, this field will only exist for one or two releases and is only used in a few places.
Suggestions for a shorter name without loss of much information are welcome!
There was a problem hiding this comment.
I didn't mean to criticize the length of the field name :) I think it's totally fair and appropriate :D As otherwise stated, I usually prefer verbose, clear names but I'll take any chance that I can get to bring up my favorite Welsh train station 🚂
| @@ -640,6 +648,7 @@ Flags: | |||
| --compound.infoblox-dns.ratelimiter.enabled enables rate limiter for DNS provider requests of controller compound | |||
| --compound.infoblox-dns.ratelimiter.qps int maximum requests/queries per second of controller compound | |||
| --compound.lock-status-check-period duration interval for dns lock status checks of controller compound | |||
| --compound.max-metadata-record-deletions-per-reconciliation int maximum number of metadata owner records that can be deleted per zone reconciliation of controller compound | |||
There was a problem hiding this comment.
Probably irrelevant: I'm only mentioning it since the options list is so neatly formatted already: Strictly speaking, all lines would have to be indented again 🙃
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The creation and management of metadata DNS records holding the owner identifier for each
DNSEntryhas been removed.These metadata DNS records will be removed automatically. To avoid running into rate limits, this removals will happen only during updates or with low batch size during the periodic reconciliation.
Depending on the size of the hosted zone the cleanup can take multiple days for very large hosted zone.
To ensure the correct work of the cleanup of these special
TXTDNS records, the owner identifier provided via the--identifiercommand line option and theDNSOwnercustom resources must still be provided.These identifiers are only used for cleanup, but not for any other purposes.
These ownership information was used to several purposes:
Please note that these edge cases are not supported anymore.
For handing over responsibility of DNS record, please use the
dns.gardener.cloud/ignore=trueannotation onDNSEntriesor the annotated source objects (likeIngress,Service, etc.)Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: