Fix indentation of skaffold.yaml #939
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-3
added
reviewed/ok-to-test
|
/test pull-etcd-druid-e2e-kind |
ishan16696
force-pushed
the
fix/skafflod
branch
from
68e97c5 to
336c3b0
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
ishan16696
force-pushed
the
fix/skafflod
branch
from
336c3b0 to
61e2af9
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
nopes, I run this |
|
There are indentation error, as you also see in your IDE: |
|
There is an indentation error, but the actual issue is not fixed. Not able to render the yaml ✗ ./hack/tools/bin/skaffold render -p gcp-setup -m druid-e2e
parsing skaffold config: failed to apply profiles to config "druid-e2e" defined in file "/private/tmp/etcd-druid/skaffold.yaml": applying profile "gcp-setup": invalid path: /manifests/kustomize/hooks/before/-. There's an issue with one of the profiles defined in config "druid-e2e" in file "/private/tmp/etcd-druid/skaffold.yaml"; refer to the documentation on how to author valid profiles: https://skaffold.dev/docs/environment/profiles/. |
please refer to the issue: #938 which I have mentioned in the PR, I have never mentioned that this PR will fix this gcp thingy which you are referring to ... currently this PR only fixes this issue which this PR is referring to as I was unable to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area testing
/kind bug
What this PR does / why we need it:
This PR fixes the indentation problem of
skaffold.yamlto run druid e2e tests withmake ci-e2e-kind.Which issue(s) this PR fixes:
Fixes #938
Special notes for your reviewer:
Release note: