CredentialsBinding Support #2336
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # frontend/src/views/GProjectPlaceholder.vue
Use 'Secret' as term for CUD action buttons (as we currently only support modifying secrets)
# Conflicts: # .pnp.cjs
Added info dialog to inform users about additional bindings when editing or deleting a secret/binding
Pass credentialsBinding to components where we already show secretBinding
gardener-robot
added
size/xl
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
…ard into enh/credentials-bindings
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
|
@holgerkoser You have pull request review open invite, please check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Gardener recently introduced
CredentialsBindingresources, which can be considered enhanced versions ofSecretBindings. In addition to referencingSecretresources, these new bindings also allow referencingWorkloadIdentitytokens. This PR adds support for viewing, editing, and creatingCredentialsBindingsthat referenceSecrets. NewSecretswill always be created with aCredentialsBinding. ExistingSecretBindingscan still be updated using the dashboard, however it will not be possible to create newSecretBindingswith the dashboard.CredentialsBindingsthat referenceWorkloadIdentitytokens will be displayed in the dashboard and can be used to create clusters. However, the dashboard currently does not support editing these bindings in any way (including deletion). The Secrets page has been renamed to Credentials and a new column has been introduced to differentiate the binding types (as there can be name clashes). Furthermore, starting with this PR, the dashboard will display a hint to the user when a secret is referenced by another binding, indicating that updating the secret will affect those bindings as well. Additionally, logic is in place to prevent secrets from being deleted if they are referenced by another binding.Which issue(s) this PR fixes:
Fixes #2147
Special notes for your reviewer:
Release note: