Improved usage of VDataTableVirtual #2291
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pass ref to ensure correct row height measurement - Introduced GScrollContainer Component to indicate more content is available - Optimized worker, ticket labels and access restrictions layout on cluster list - Use VDataVirtual for Secret & Member Page - Introduced useTwoTableLayout composable for optimized two table page layouting
gardener-robot
added
needs/review
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
grolu
changed the title
gardener-robot-ci-3
added
reviewed/ok-to-test
grolu
changed the title
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
|
@grolu You need rebase this pull request with latest master branch. Please check. |
petersutter
reviewed
Feb 26, 2025
| const { height: containerHeight } = useElementSize(containerRef) | ||
|
|
||
| const desiredFirstTableHeight = computed(() => { | ||
| const contentHeight = firstTableItemCount.value * (itemHeight + 1) |
There was a problem hiding this comment.
well I added this to try to compensate the fact that the table adds srollbars even if the calculated height matches exactly the content height. Looking at it now it seems to only make it worse. Let's remove it.
|
there is also a conflict that has to be solved. In addition, I noticed the following bug (as discussed offline) Go to some Project, make sure to deselect the worker column from the table options |
gardener-robot-ci-2
added
reviewed/ok-to-test
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: