Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End to End Reactivity for Project Resources #2222

Merged
merged 27 commits into from
Feb 11, 2025
Merged

End to End Reactivity for Project Resources #2222

merged 27 commits into from
Feb 11, 2025

Conversation

holgerkoser
Copy link
Member

@holgerkoser holgerkoser commented Dec 6, 2024 •
edited by petersutter
Loading

What this PR does / why we need it:
This PR makes the project resource reactive so that we receive updates via websocket connection.
The dashboard frontend logic is adapted to react to project resource changes, deletion etc.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Real-time updates for projects are now supported. Changes and deletions to projects are instantly reflected in the frontend through the WebSocket connection.

@holgerkoser holgerkoser marked this pull request as draft December 6, 2024 16:27
@gardener-robot gardener-robot added the needs/review Needs review label Dec 6, 2024
@holgerkoser holgerkoser changed the title End to End Reactivity [DRAFT] End to End Reactivity Dec 6, 2024
@gardener-robot gardener-robot added the size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) label Dec 6, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 6, 2024
@gardener-robot gardener-robot added the needs/second-opinion Needs second review by someone else label Dec 6, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 6, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 9, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 11, 2024
@holgerkoser
move event handler code to composable
8d417fa
@holgerkoser
Merge branch 'master' into enh/kube-watch
7da6c62 
* master:
  fix: Use correct URL for shoot credentials rotation page (#2221)
  fix: Use correct link for control plane high availability documentation (#2225)
  Update dependency @codemirror/view to v6.35.2 (#2224)
  Update dependency @codemirror/view to v6.35.1 (#2220)
  Update dependency express to v4.21.2 (#2219)
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 11, 2024
@holgerkoser holgerkoser marked this pull request as ready for review December 12, 2024 08:25
@holgerkoser holgerkoser marked this pull request as draft December 12, 2024 08:25
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 7, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 7, 2025
@petersutter
fix "Multiple nodes with the same ID" error
d272684
@petersutter
fix issue that component gets destroyed when readyState changes
c2eab90 
Switching between Overview and YAML tab on create new shoot editor caused the GNewShootPlaceholder to be re-created'
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 10, 2025
@petersutter petersutter mentioned this pull request Feb 11, 2025
Open
@petersutter petersutter changed the title [DRAFT] End to End Reactivity End to End Reactivity Feb 11, 2025
@grolu grolu changed the title End to End Reactivity End to End Reactivity for Project Ressources Feb 11, 2025
@grolu grolu changed the title End to End Reactivity for Project Ressources End to End Reactivity for Project Resources Feb 11, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 11, 2025
@petersutter petersutter marked this pull request as ready for review February 11, 2025 10:21
grolu
grolu approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/rebase Needs git rebase needs/review Needs review needs/second-opinion Needs second review by someone else labels Feb 11, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 11, 2025
@petersutter petersutter merged commit 03b0f32 into master Feb 11, 2025
10 checks passed
@petersutter petersutter deleted the enh/kube-watch branch February 11, 2025 12:45
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Feb 11, 2025
@petersutter petersutter mentioned this pull request Nov 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petersutter petersutter petersutter approved these changes

@grolu grolu grolu approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@holgerkoser @gardener-robot @petersutter @grolu @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3