Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Reapply "Add [email protected] into krte image (#3250)" (#3299) #3301

Conversation

marc1404
Copy link
Member

@marc1404 marc1404 commented Mar 3, 2025

/kind cleanup

What this PR does / why we need it:

This reverts commit cbd56e3 (#3299).

The relevant PR in g/g is not merged yet.

Which issue(s) this PR fixes:

n.a.

Special notes for your reviewer:
/cc @LucaBernstein

@gardener-prow gardener-prow bot requested a review from LucaBernstein March 3, 2025 08:56
@gardener-prow gardener-prow bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 3, 2025
@marc1404
Copy link
Member Author

marc1404 commented Mar 3, 2025

/kind cleanup

@gardener-prow gardener-prow bot added kind/cleanup Something that is not needed anymore and can be cleaned up and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 3, 2025
Copy link
Member

@LucaBernstein LucaBernstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2025
Copy link

gardener-prow bot commented Mar 3, 2025

LGTM label has been added.

Git tree hash: 6c55d97a92fcd645710deadaa8ffc83b7f9b5741

Copy link

gardener-prow bot commented Mar 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LucaBernstein

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2025
@LucaBernstein
Copy link
Member

See: gardener/gardener#11532

@gardener-prow gardener-prow bot merged commit 18ede5b into gardener:master Mar 3, 2025
5 checks passed
@marc1404 marc1404 deleted the chore/revert-revert-add-runc-into-krte-image branch March 3, 2025 09:01
marc1404 added a commit to marc1404/ci-infra that referenced this pull request Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/cleanup Something that is not needed anymore and can be cleaned up lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants