Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jobs and config for gardener-extension-provider-equinix-metal #2536

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add jobs and config for gardener-extension-provider-equinix-metal #2536

wants to merge 3 commits into from

Conversation

RiRa12621
Copy link

/kind enhancement
/kind test

What this PR does / why we need it:
We would like to use prow for gardener-extension-provider-equinix-metal related tests as well to unifi the experience

@gardener-prow gardener-prow bot added kind/enhancement Enhancement, improvement, extension kind/test Test labels Oct 16, 2024
@gardener-prow gardener-prow bot requested review from acumino and ary1992 October 16, 2024 19:09
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 16, 2024
@RiRa12621
Copy link
Author

/assign @acumino
obey the bots

@gardener-ci-robot
Copy link
Collaborator

The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

  • After 15d of inactivity, lifecycle/stale is applied
  • After 15d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 7d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Mark this PR as rotten with /lifecycle rotten
  • Close this PR with /close

/lifecycle stale

@gardener-prow gardener-prow bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 31, 2024
@gardener-ci-robot
Copy link
Collaborator

The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

  • After 15d of inactivity, lifecycle/stale is applied
  • After 15d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 7d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close

/lifecycle rotten

@gardener-prow gardener-prow bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 15, 2024
@oliver-goetz
Copy link
Member

/remove-lifecycle rotten

@gardener-prow gardener-prow bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Nov 19, 2024
oliver-goetz
oliver-goetz requested changes Nov 19, 2024
View reviewed changes
Copy link
Member

@oliver-goetz oliver-goetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's nice that you plan to enable prow for the equinix metal extension 🙂
I'm sorry that the review took so long.

There are a couple of things to be changed apart from my review comment:

  • you might want to enable branch protection similar to how it is done for cert-management as both repos still use concourse jobs.
  • please add the label sync for your repository, again similar to cert-management (ref1, ref2)
  • You could add your repository to the config of the lifecycle bot (ref)
  • You should add OWNERS and OWNER_ALIASES files to the root of your repository. There are examples how they look like in this repository.
  • If you like you can add your repo to the renovate config and run make generate-prow-deployments afterwards

config/prow/config.yaml
- do-not-merge/release-note-label-needed
- do-not-merge/work-in-progress
- needs-rebase
- "cla: no"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase please, because we deduplicated the tide config with #2609

@gardener-prow Gardener Prow
Copy link

gardener-prow bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from acumino. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow Gardener Prow
Copy link

gardener-prow bot commented Nov 20, 2024

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gardener-prow gardener-prow bot added the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Nov 20, 2024
@gardener-ci-robot
Copy link
Collaborator

The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

  • After 15d of inactivity, lifecycle/stale is applied
  • After 15d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 7d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Mark this PR as rotten with /lifecycle rotten
  • Close this PR with /close

/lifecycle stale

@gardener-prow gardener-prow bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-goetz oliver-goetz oliver-goetz requested changes

@acumino acumino Awaiting requested review from acumino

@ary1992 ary1992 Awaiting requested review from ary1992

Assignees

@acumino acumino

@oliver-goetz oliver-goetz

Labels
cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. kind/enhancement Enhancement, improvement, extension kind/test Test lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RiRa12621 @gardener-ci-robot @oliver-goetz @acumino