Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop correlation_id from snapshots and add utility function #1177

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

8R0WNI3
Copy link
Member

@8R0WNI3 8R0WNI3 commented Feb 27, 2025

Release note:

Dropped the `correlation_id` property from compliance snapshots (ODG)

Utility function to create a dictionary representation of artefacts of
type `ComponentArtefactId`. The difference to utilising
`dataclasses.asdict` is that
(1) the keys are intended to be more human readable
(2) the resulting dictionary is not nested anymore.
Especially useful to display an artefact as part of a GitHub issue.
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Feb 27, 2025
Copy link
Member

@ccwienk ccwienk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you do like ternary operator :-)

@gardener-robot
Copy link

@zkdev, @TuanAnh17N You have pull request review open invite, please check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants