Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add oci-ocm-multiarch workflow #1174

Merged
merged 6 commits into from
Mar 5, 2025
Merged

add oci-ocm-multiarch workflow #1174

merged 6 commits into from
Mar 5, 2025

Conversation

ccwienk
Copy link
Member

@ccwienk ccwienk commented Feb 27, 2025

Release note:

add reusable workflow `oci-ocm-multiarch` that will allow building multi-arch OCI Images, running the build-jobs on runners w/ matching platform, if available.

@gardener-robot gardener-robot added needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Feb 27, 2025
@ccwienk ccwienk force-pushed the oci-ocm-build-workflow branch from b8b72d3 to f54888a Compare February 27, 2025 11:58
@ccwienk ccwienk force-pushed the oci-ocm-build-workflow branch from f54888a to 647e157 Compare February 27, 2025 12:01
@ccwienk
Copy link
Member Author

ccwienk commented Feb 27, 2025 •
edited
Loading

there are still a couple of open TODOs (which I plan to add to this pullrequest):

  • re-use in cc-utils + concourse-repository
  • add prebuild-hook (required by both cc-utils, and concourse-repository)
  • upload ocm-resource-fragments as artefacts (to support more than one image - thanks GHA for making such simple things so cumbersome)
  • maybe: add option to import commit
  • maybe (probably separate pullrequest): export/merge-ocm-fragment-actions

8R0WNI3
8R0WNI3 reviewed Feb 27, 2025
View reviewed changes
@ccwienk ccwienk force-pushed the oci-ocm-build-workflow branch from 4dda28d to a6f3306 Compare February 27, 2025 21:39
@ccwienk ccwienk force-pushed the oci-ocm-build-workflow branch from a6f3306 to 35083f6 Compare February 27, 2025 21:50
@ccwienk ccwienk force-pushed the oci-ocm-build-workflow branch from 35083f6 to f893cbf Compare February 28, 2025 07:24
@ccwienk ccwienk requested a review from 8R0WNI3 February 28, 2025 07:24
@gardener-robot
Copy link

@zkdev, @TuanAnh17N You have pull request review open invite, please check

@ccwienk
add oci-ocm-multiarch workflow
dda90df 
With the advent of arm64-runners, it makes sense to have a convenient
reusable workflow for building multiarch OCI-Images (grouped in single
OCI Indexes), delegating image-builds to native runners (to avoid
overhead from emulation).

As runners can only be specified on job-level, this cannot be achieved
using an action (as done w/ ocm-oci-build action), hence use a reusable
workflow. Unfortunately, workflows are less flexible w.r.t.
customations, which results in a wider set of input-parameters.
@ccwienk
Copy link
Member Author

ccwienk commented Mar 4, 2025

there are still a couple of open TODOs (which I plan to add to this pullrequest):

  • re-use in cc-utils + concourse-repository
  • add prebuild-hook (required by both cc-utils, and concourse-repository)
  • upload ocm-resource-fragments as artefacts (to support more than one image - thanks GHA for making such simple things so cumbersome)
  • maybe: add option to import commit
  • maybe (probably separate pullrequest): export/merge-ocm-fragment-actions

I think it will make more sense to work on the third and fifth bullet-point in a separate pullrequest (+ to drop the fourth until actually needed)

8R0WNI3
8R0WNI3 reviewed Mar 4, 2025
View reviewed changes
@ccwienk ccwienk force-pushed the oci-ocm-build-workflow branch from f893cbf to c49f4e6 Compare March 4, 2025 21:25
@ccwienk ccwienk requested a review from 8R0WNI3 March 4, 2025 21:26
@ccwienk
Copy link
Member Author

ccwienk commented Mar 4, 2025

note to self: remember to autosquash prior to merging

8R0WNI3
8R0WNI3 approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@8R0WNI3 8R0WNI3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Mar 5, 2025
@ccwienk ccwienk force-pushed the oci-ocm-build-workflow branch from c49f4e6 to f9fbeb8 Compare March 5, 2025 06:56
@gardener-robot gardener-robot added the needs/second-opinion Needs second review by someone else label Mar 5, 2025
@ccwienk ccwienk merged commit f85d457 into master Mar 5, 2025
5 checks passed
@ccwienk ccwienk deleted the oci-ocm-build-workflow branch March 5, 2025 06:56
@gardener-robot gardener-robot added status/closed Issue is closed (either delivered or triaged) and removed reviewed/lgtm Has approval for merging labels Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@8R0WNI3 8R0WNI3 8R0WNI3 approved these changes

@zkdev zkdev Awaiting requested review from zkdev zkdev is a code owner

@TuanAnh17N TuanAnh17N Awaiting requested review from TuanAnh17N TuanAnh17N is a code owner

Assignees
No one assigned
Labels
needs/second-opinion Needs second review by someone else size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ccwienk @gardener-robot @8R0WNI3