[cherry-pick-v1.30] Fix Race conditions in Targeted Deletion of machines by CA (#341) #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * [WIP] fix CA marking machines for deletion * [WIP] add mutex for machine deployment * initialise machinedeployment map in mcmManager * add Refresh method in nodegrp implementation * address review comments * address review comments - part 2 * update unit tests, misc code changes * review comments addressed * fixed broken test after refactor * fixed broken test * alternate solution using single annotation for deletion by CA * fixed use of Go 1.23 functions * fixed test * added godoc for AcquireScalingMutex * correct godoc for machinesMarkedByCAForDeletionAnnotation * changed to machineutils.TriggerDeletionByMCM * removed var shadowing, added TODO to godoc for util fns * corr var names, clear mutex acquire, releasing logs * ensured IncreaseSize/DecreaseTargetSize logged delta in mutex acquire/release log * review comments addressed: fixed unit test, adjusted log, removed redundant fn * all code review comments addressed * review feedback: unexport belongs, enforce interface * addreseed review comment, refactored added test for computeScaleDownData * review comment: preset capacity for slices * review feedback: ->computeScaleDownData and revised godoc * cordon nodes fix for when node is disabled for scaledown * fixed unit test string quoting issue --------- Co-authored-by: Rishabh Patel <[email protected]> Co-authored-by: elankath <[email protected]>
gardener-robot
added
needs/review
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
elankath
approved these changes
Feb 4, 2025
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR cherry picks the the following commit:
edd7d34dWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: