Sync the VPA fork with the upstream/vpa-release-1.2 #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vpa-release-1.2 branch I used: ``` git checkout upstream/vpa-release-1.2 vertical-pod-autoscaler/ ```
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot
added
size/xl
ialidzhikov
requested review from
himanshu-kun,
unmarshall,
rishabh-11 and
a team
as code owners
gardener-robot
added
reviewed/lgtm
aaronfern
merged commit d9666fe
into
gardener:rel-vertical-pod-autoscaler
5 checks passed
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We found a regression in VPA 1.2.0: see kubernetes#7161. As we merged many PRs that depend on the VPA 1.2.0 we decided to cut a release from the fork. @plkokanov and @voelzmo anyways wanted to use a custom vpa-recommender image with additional logging to debug one recurring issue.
1st commit: Sync the vertical-pod-autoscaler/ dir with the content from upstream/vpa-release-1.2 branch
I used:
This intentionally reverts the additional logging added in Add logging in case we have minimum memory recommendations #299. @plkokanov will raise a new PR about it with small modifications
nil pointer dereferencekubernetes/autoscaler#7161Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
N/A
Release note: