-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync upstream v1.30.1 #317
Sync upstream v1.30.1 #317
Conversation
Consider atomic nodes
This change adds the informer factory as an argument to the `buildCloudProvider` function for clusterapi so that building with tags will work properly.
…-owner-ref [VPA] check OwnerRef against TargetRef to confirm VPA/Pod association
…c-improvement doc: cluster-autoscaler: Oracle provider: Add small security note
Update the VPA Version to v1.0.0
Bump CA Chart image to v1.29
…ar-to-reviewers chore: add vadasambar to cluster-autoscaler reviewers
…s_equinixmetal Added the RBAC Permission to equinixmetal Cloud Provider.
…enaming Update Auto Labels of Subprojects
chore: remove unused arg from StaticAutoScaler
…mCloudProvider-panic fix: panic in deleteNodesFromCloudProvider
Stop (un)tainting nodes from unselected node groups.
Co-authored-by: Shubham <[email protected]>
@@ -0,0 +1,4061 @@ | |||
I0708 14:05:09.210791 60673 main.go:647] Cluster Autoscaler 1.30.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is added by error I guess. Can you please remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Few minor changes requested. Please address them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Few minor changes requested. Please address them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
/lgtm
e9e32f3
into
gardener:machine-controller-manager-provider
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #304
Special notes for your reviewer:
Release note: