Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick of #309 #312

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Cherry-pick of #309 #312

merged 1 commit into from
Jul 4, 2024

Conversation

rishabh-11
Copy link

@rishabh-11 rishabh-11 commented Jul 4, 2024 •
edited
Loading

What this PR does / why we need it:
Cherry-pick of #309

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fixed a bug where the instance status was nil when `machine.Status.LastOperation.Type` = `Create` causing it to not be considered as an unregistered Node and thereby cluster autoscaler never removing it

@rishabh-11 rishabh-11 requested review from himanshu-kun, unmarshall and a team as code owners July 4, 2024 08:24
@gardener-robot gardener-robot added the needs/review Needs review label Jul 4, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 4, 2024
@gardener-robot gardener-robot added the size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) label Jul 4, 2024
aaronfern
aaronfern approved these changes Jul 4, 2024
View reviewed changes
Copy link

@aaronfern aaronfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jul 4, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 4, 2024
@elankath
Copy link

elankath commented Jul 4, 2024

Possible to add a unit-test for generateInstanceStatus ?

@rishabh-11
Copy link
Author

Possible to add a unit-test for generateInstanceStatus ?

MCM manager, in general, has a very low unit testing. As we are looking into MCM-CA overhaul, we can do it later if required at all.

@rishabh-11 rishabh-11 merged commit dce435f into gardener:rel-v1.29 Jul 4, 2024
10 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 4, 2024
@rishabh-11 rishabh-11 deleted the instance-status branch July 4, 2024 08:46
@rishabh-11 rishabh-11 self-assigned this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronfern aaronfern aaronfern approved these changes

@himanshu-kun himanshu-kun Awaiting requested review from himanshu-kun

@unmarshall unmarshall Awaiting requested review from unmarshall unmarshall is a code owner

Assignees

@rishabh-11 rishabh-11

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rishabh-11 @elankath @aaronfern @gardener-robot-ci-1 @gardener-robot