Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support ephemeral-storage and custom extended resouces #311

Closed
wants to merge 6 commits into from
Closed

support ephemeral-storage and custom extended resouces #311

wants to merge 6 commits into from

Conversation

elankath
Copy link

@elankath elankath commented Jul 4, 2024 •
edited
Loading

What this PR does / why we need it:

Right now in scale-from-zero cases, the autoscaler does not respect ephemeral-storage extended resource specified in the MachineClass.NodeTemplate . Only the standard cpu, gpu and memory are picked up. Neither is there any support for custom extended resource which are fully ignored presently.

Which issue(s) this PR fixes:
Fixes #132

Special notes for your reviewer:

Release note:

Support ephemeral-storage and extended resources specified in MachineClass Node Template

@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Jul 4, 2024
@elankath elankath marked this pull request as draft July 4, 2024 08:19
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 4, 2024
@elankath elankath added status/in-progress Issue is in progress/work and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 4, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 4, 2024
@elankath elankath self-assigned this Jul 9, 2024
@elankath
Copy link
Author

elankath commented Jul 11, 2024 •
edited
Loading

NOTE: This PR is in the process of being changed to support custom extended resources (not only ephemeral-storage) for supporting Pod specs with custom resources in all scaling cases. (not just scale-from-zero). This is currently WIP.

@elankath elankath changed the title WIP: support extended resouces in scale from zero WIP: support ephemeral-storage and other custom extended resouces in scale from zero Jul 11, 2024
@elankath elankath changed the title WIP: support ephemeral-storage and other custom extended resouces in scale from zero WIP: support ephemeral-storage and other custom extended resouces Jul 11, 2024
@gardener-robot gardener-robot added size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) and removed size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Jul 23, 2024
@elankath elankath changed the title WIP: support ephemeral-storage and other custom extended resouces support ephemeral-storage and custom extended resouces Jul 23, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 23, 2024
@elankath elankath removed the needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 23, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 23, 2024
@elankath elankath marked this pull request as ready for review July 23, 2024 09:12
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 23, 2024
@gardener-robot gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else and removed size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Jul 23, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 23, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 23, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 23, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 23, 2024
@elankath
Copy link
Author

elankath commented Nov 7, 2024

Closed in favour of #334

@elankath elankath closed this Nov 7, 2024
@gardener-robot gardener-robot added status/closed Issue is closed (either delivered or triaged) and removed status/in-progress Issue is in progress/work labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himanshu-kun himanshu-kun Awaiting requested review from himanshu-kun

@unmarshall unmarshall Awaiting requested review from unmarshall unmarshall is a code owner

@rishabh-11 rishabh-11 Awaiting requested review from rishabh-11 rishabh-11 is a code owner

Assignees

@elankath elankath

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow a way to specify extended resources for scale-from-zero scenario
5 participants
@elankath @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot