Updated NodeGroupAutoscalingOptions to now include all options #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfern
requested review from
himanshu-kun,
unmarshall,
rishabh-11 and
a team
as code owners
gardener-robot
added
needs/review
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-2
added
needs/ok-to-test
rishabh-11
merged commit 962e5dd
into
gardener:machine-controller-manager-provider
10 checks passed
gardener-robot
added
the
status/closed
aaronfern
added a commit
to aaronfern/autoscaler
that referenced
this pull request
Jul 4, 2024
aaronfern
added a commit
to aaronfern/autoscaler
that referenced
this pull request
Jul 4, 2024
rishabh-11
pushed a commit
that referenced
this pull request
Jul 4, 2024
rishabh-11
pushed a commit
that referenced
this pull request
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes a bug where some default parameters for node group defaults were not correctly set.
Which issue(s) this PR fixes:
Fixes #308
Special notes for your reviewer:
Release note: