Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn users on 32-bit CPUs and big-endian CPUs #5074

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ChrisJefferson
Copy link
Contributor

This PR adds a message which is displayed whenever GAP is started on a 32-bit CPU, or a big-endian CPU, pointing out that GAP don't support this CPU, and we aren't doing full testing.

There are I feel two questions here:

  1. Is adding such a message reasonable? I think it is, because in general people want to trust the answers they get from GAP.

  2. Is this message right? Here's what the output looks like:

 ┌───────┐   GAP 4.13dev-42-g7cf6fb7 built on 2022-09-29 20:35:04+0100
 │  GAP  │   https://www.gap-system.org
 └───────┘   Architecture: x86_64-pc-linux-gnu-default64-kv8

 **** Warning, this copy of GAP was built for: 32-bit CPUs
 **** This configuration is not officially supported or tested

 Configuration:  gmp 6.2.1, GASMAN, readline
 Loading the library and packages ...

@ChrisJefferson ChrisJefferson added do not merge PRs which are not yet ready to be merged (e.g. submitted for discussion, or test results) kind: discussion discussions, questions, requests for comments, and so on labels Sep 29, 2022
@fingolfin
Copy link
Member

I am fine with this in principle, but we should not do this silently. Instead I'd suggest to bring this PR up on the GAP mailing list, so that people have a chance to react and comment. Do you want to do that, @ChrisJefferson ?

This also ties in with #5026 ...

@fingolfin
Copy link
Member

If we do this, we might as well also drop the (soon broken) 32bit package tests from CI; see also discussion in PR #5026.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge PRs which are not yet ready to be merged (e.g. submitted for discussion, or test results) kind: discussion discussions, questions, requests for comments, and so on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants