kernel: change SyExecuteProcess to use posix_spawn
#4799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
topic: kernel
release notes: not needed
fingolfin
added
the
os: windows
|
This works on cygwin, and stops the directory changing behaviour |
ChrisJefferson
approved these changes
Mar 4, 2022
fingolfin
force-pushed
the
mh/SyExecuteProcess-posix_spawn
branch
from
2f788fa
to
e1079b6
Compare
fingolfin
changed the title
SyExecuteProcess to use posix_spawnSyExecuteProcess to use posix_spawn
|
I decided to just make the move of |
fingolfin
commented
Apr 19, 2022
| return -1; | ||
| } | ||
|
|
||
| // wait for some action |
There was a problem hiding this comment.
Note: the "classic" code using fork also has some logic to "ignore a CTRL-C". And it disables our SIGCHLD handler temporarily. We may need to add one or both back here.
fingolfin
force-pushed
the
mh/SyExecuteProcess-posix_spawn
branch
from
e1079b6
to
77c3dcd
Compare
fingolfin
force-pushed
the
mh/SyExecuteProcess-posix_spawn
branch
from
77c3dcd
to
75a535a
Compare
fingolfin
force-pushed
the
mh/SyExecuteProcess-posix_spawn
branch
from
75a535a
to
3b4905d
Compare
fingolfin
force-pushed
the
mh/SyExecuteProcess-posix_spawn
branch
from
3b4905d
to
8c0b2d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ChrisJefferson does this work under cygwin? If so, does it fix the bug where
Processis changing the working dir for the parent process?The patch is not ready for merging in any case:
SyExecuteProcesstoiostream.cis kind of a hack, but for the sake of quickly experimenting I didn't want to bother with trying to come up with a "clean" solution.