code refactoring

[stahanna]

No description provided.

[bkhelifi]

Thank you @stahanna.
I think that there is a commit issue in this PR:

• there are the tutorials', download` folders that are not belonging to the website project. Can you remove them?
• All other files (e.g. the song or the images) seem to be modified, but I am rather sure that this is not the case. @registerrier, do you understand how we can fix that with a git command?

[registerrier]

Well there are 530 commits in this PR, that's the full history of commits on the repo :-) I don't know how this is possible. I think closing and reopening a clean PR is the only way.

[stahanna]

@bkhelifi I have deleted the downloads and templates

[registerrier]

I think I understand. The PR is on the master branch, where the changes should be on gh-pages.
@stahanna close this PR, restart from a clean branch from gh-pages and open a new PR on gh-pages.

@bkhelifi There is a tutorials folder on the webpage. That's how we distribute the notebooks with gammapy download.

[bkhelifi]

@registerrier, Hanna seems to have reverted the bad commits. Do you think that one can merge it?
This is so sad that one can not see the output before the merge. The use of JS complexifies the preview, I guess.

[registerrier]

@registerrier, Hanna seems to have reverted the bad commits. Do you think that one can merge it? This is so sad that one can not see the output before the merge. The use of JS complexifies the preview, I guess.

The PR is not on the correct branch!
It cannot be merged or we loose the all the configuration for binder that is on master for no change in the webpage that is on the gh-pages branch.

[bkhelifi]

Well seen. I close the PR, @stahanna... And then you can restart from the clean version of the branch gh-pages of your fork (which is the current active primary branch), and create a new branch from it.