Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove encryption to remove PyCrypto dependency #94

Merged
merged 6 commits into from
Feb 28, 2025

Conversation

kroq-gar78
Copy link
Contributor

@kroq-gar78 kroq-gar78 commented Feb 3, 2025

Some example notebooks and docs (gendoc) still mention it.

This would make #93 obsolete.

@kroq-gar78
Copy link
Contributor Author

kroq-gar78 commented Feb 4, 2025

Looks like this repo hasn't enabled automatic tests for PRs yet. That would require the top of .github/workflows/run_tests.yml to look like this: https://github.com/gallantlab/pycortex/blob/main/.github/workflows/run_tests.yml#L3-L9

That said I ran the tests locally and they seemed fine.

Some example notebooks and docs still mention it
@mvdoc mvdoc force-pushed the remove-encryption branch from 513ead2 to a4f7861 Compare February 28, 2025 18:12
@mvdoc mvdoc merged commit e1b83d5 into gallantlab:main Feb 28, 2025
3 checks passed
@kroq-gar78
Copy link
Contributor Author

Thanks for merging! and also fixing the dask test. I was about to submit a PR for that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants