Fix our RTL support for RTL languages #4896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when viewing the training materials in (e.g.) arabic, it does not render correctly according to RTL expectations.
Ignoring my lack of font support, everything is displayed incorrectly, on the left.
It should all be on the right, but note that the 'tab' on the box is still on the wrong side, it should be on the right.
This PR fixes that by replacing
-leftwith-inline-startin the appropriate places and addingdir="auto"to ensure that if the GTN is loaded in an RTL language (through google translate) that we are giving the user the experience they are used to and expect.See this for more details
https://firefox-source-docs.mozilla.org/code-quality/coding-style/rtl_guidelines.html