Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ecoregionalization_tutorial #4682

Merged
merged 66 commits into from
Sep 16, 2024
Merged

Add Ecoregionalization_tutorial #4682

merged 66 commits into from
Sep 16, 2024

Conversation

PaulineSGN
Copy link
Contributor

@PaulineSGN PaulineSGN commented Jan 29, 2024 •
edited
Loading

No description provided.

@PaulineSGN PaulineSGN requested a review from a team as a code owner January 29, 2024 13:41
hexylena
hexylena reviewed Jan 29, 2024
View reviewed changes
Copy link
Member

@hexylena hexylena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @PaulineSGN welcome to the GTN! Exciting to see a new tutorial in this topic :)

topics/ecology/tutorials/Ecoregionalization_tutorial/tutorial.md Outdated Show resolved Hide resolved
topics/ecology/tutorials/Ecoregionalization_tutorial/tutorial.md Outdated Show resolved Hide resolved
topics/ecology/tutorials/Ecoregionalization_tutorial/tutorial.md Outdated Show resolved Hide resolved
@PaulineSGN
Copy link
Contributor Author

Hi @hexylena, thanks a lot for your review ! I will take into account your comments and modify the tutorial.

PaulineSGN and others added 21 commits January 29, 2024 16:02
@PaulineSGN
Update tutorial.md
f3ef595
@PaulineSGN
Update CONTRIBUTORS.yaml
7e3479f
@PaulineSGN
New sections titles
69a6998
@PaulineSGN
Merge branch 'galaxyproject:main' into PaulineSGN-patch-1
1763ceb
@yvanlebras
first pass until BRT tool execution
ea11a4e
@yvanlebras
second pass until ClaraClust step
f451670
@PaulineSGN
Update tutorial.md (add alt-text)
52a63f6
@PaulineSGN
Update tutorial.md
642cf05
@PaulineSGN
Update CONTRIBUTORS.yaml
91d8c94
@PaulineSGN
Update tutorial.md
f71c834
@PaulineSGN
Update tutorial.md
7640489
@PaulineSGN
Add files via upload
e8a5147
@PaulineSGN
Add files via upload
6e255be
@PaulineSGN
Update tutorial.md
e59410b
@PaulineSGN
Delete topics/ecology/tutorials/Ecoregionalization_tutorial/workflows…
56c3995 
…/main_workflow.ga
@PaulineSGN
Add files via upload
56e4f67
@PaulineSGN
Merge branch 'galaxyproject:main' into PaulineSGN-patch-1
7aef1ba
@PaulineSGN
Merge branch 'galaxyproject:main' into PaulineSGN-patch-1
017850d
@PaulineSGN
Add workflow tests
4e8ac8b
@PaulineSGN
Delete topics/ecology/tutorials/Ecoregionalization_tutorial/workflows…
42fed8d 
…/Ecoregionalization_Workflow_tests.yml
@PaulineSGN
correct file name
8cd290e
hexylena
hexylena previously approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@hexylena hexylena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine from a GTN perspective, @yvanlebras do you want to review the content otherwise?

topics/ecology/tutorials/Ecoregionalization_tutorial/tutorial.md Outdated Show resolved Hide resolved
@yvanlebras
Copy link
Collaborator

Hmmm, any idea @bgruening @hexylena why this kind of message appears ?

For the Links > Internal check, the following failures were found:

* At ./_site/training-material/topics/ecology/tutorials/Ecoregionalization_tutorial/tutorial.html:598:

  internally linking to toolshed.g2.bx.psu.edu/repos/imgteam/unzip/unzip/6.0+galaxy0, which does not exist

Looking at the manner tools ID are quoted seem to be ok for me isn't it? Sorry if I miss something, and enjoy the summer !

hexylena
hexylena reviewed Jul 29, 2024
View reviewed changes
topics/ecology/tutorials/Ecoregionalization_tutorial/tutorial.html Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should not be an html file here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh! you've rendered the GTN markdown with Pandoc, there are better ways (gitpod, locally).

Removing this file will fix your linting complaints

yvanlebras
yvanlebras previously approved these changes Jul 30, 2024
View reviewed changes
yvanlebras
yvanlebras previously approved these changes Sep 16, 2024
View reviewed changes
@PaulineSGN
Merge pull request #2 from galaxyproject/main
519fc1c 
rebase files from gtn up website
@yvanlebras yvanlebras merged commit 6a8e422 into galaxyproject:main Sep 16, 2024
3 checks passed
@PaulineSGN PaulineSGN deleted the PaulineSGN-patch-1 branch September 16, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hexylena hexylena hexylena left review comments

@yvanlebras yvanlebras yvanlebras approved these changes

Assignees

@yvanlebras yvanlebras

Labels
ecology template-and-tools work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PaulineSGN @yvanlebras @hexylena @Marie59