Migrate WebDAV file source to fsspec/webdav4#22477
Open
PlushZ wants to merge 1 commit intogalaxyproject:devfrom
Open
Migrate WebDAV file source to fsspec/webdav4#22477PlushZ wants to merge 1 commit intogalaxyproject:devfrom
PlushZ wants to merge 1 commit intogalaxyproject:devfrom
Conversation
github-actions
bot
added
area/testing
area/dependencies
area/testing/integration
labels
davelopez
reviewed
Apr 14, 2026
Comment on lines
+264
to
+268
| def check_fs_webdavfs(self): | ||
| return self.check_webdav4() | ||
|
|
||
| def check_webdavclient3(self): | ||
| # fs.webdavfs dependency for which we need an unreleased version | ||
| return self.check_fs_webdavfs() | ||
| return self.check_webdav4() |
Contributor
There was a problem hiding this comment.
I think those are not needed anymore
Comment on lines
+68
to
+76
| def normalize_endpoint(cls, data: Any) -> Any: | ||
| if not isinstance(data, dict): | ||
| return data | ||
| normalized = dict(data) | ||
| normalized["root"] = _normalize_root(normalized.get("root")) | ||
| normalized["base_url"] = _normalize_base_url( | ||
| normalized.get("base_url") or _compose_base_url(normalized.get("url"), normalized.get("root")) | ||
| ) | ||
| return normalized |
Contributor
There was a problem hiding this comment.
The path normalization is a bit complex, and it's done at the template level, it probably should follow the same pattern as other file sources overriding _adapt_entry_path and/or _to_filesystem_path, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the WebDAV file source backend from fs.webdavfs to webdav4 via Galaxy’s FsspecFilesSource, keeping the existing user/admin config shape (url + root). The change normalizes those fields into an internal base_url, which fixes the current serialization bug where import/export jobs could lose the WebDAV endpoint after file source rehydration.
Migration sub-issue #21869
How to test the changes?
(Select all options that apply)
License