Add a Search to Invocation View#22476
Open
ahmedhamidawan wants to merge 12 commits intogalaxyproject:devfrom
Open
Add a Search to Invocation View#22476ahmedhamidawan wants to merge 12 commits intogalaxyproject:devfrom
ahmedhamidawan wants to merge 12 commits intogalaxyproject:devfrom
Conversation
Member
Author
|
How horrible is this close-search icon 🤔:
Update: Actually, no I went with this:
|
Contributor
|
I liked the ugly one! (joking...) |
Member
Author
|
@davelopez With the open-search button remaining as is, for the close search, we can do a blue + pressed version instead:
|
- Moves the results listing of the existing workflow editor search to its own component (`GraphSearch`) - Reuses that component to display results in a popover in the top right of the invocation view's tabs Fixes galaxyproject#20437
Without this check, the search in the invocation view would always fail with trying to iterate through a null cache.
ahmedhamidawan
force-pushed
the
add_graph_search_to_invocation_view
branch
from
3efcceb to
3dfbee3
Compare
…egion This way, we have removed the need to `defineExpose` a `highlightGraphRegion` method from `WorkflowGraph.vue` and instead just use this ref to highlight a graph region.
…eded Note: `stepId` is a string in `SearchData` because when we collect and cache the search data, we parse each property as a string. In the invocation search, we just convert the string to a number to set the `activeNodeId`.
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
ahmedhamidawan
force-pushed
the
add_graph_search_to_invocation_view
branch
from
3dfbee3 to
95b14b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invocation Graph Search:
GraphSearch)add_graph_search_to_invocation_view_2.mp4
Steps Tab Search
This also adds a search to the invocation steps tab:
add_search_to_invocation_steps_tab.mp4
Fixes #20437
How to test the changes?
(Select all options that apply)
License