Require logging in again when OIDC tokens can't be refreshed#22449
Open
marius-mather wants to merge 9 commits intogalaxyproject:devfrom
Open
Require logging in again when OIDC tokens can't be refreshed#22449marius-mather wants to merge 9 commits intogalaxyproject:devfrom
marius-mather wants to merge 9 commits intogalaxyproject:devfrom
Conversation
github-actions
bot
added
area/testing
area/auth
Member
|
@uwwint do you want to take a look at this ? |
nuwang
reviewed
Apr 14, 2026
Member
nuwang
left a comment
nuwang
left a comment
There was a problem hiding this comment.
Looks good to me except for one minor issue.
| log.info("OIDC refresh failed terminally for provider `%s`, forcing re-login", reauth_provider) | ||
| if self.galaxy_session: | ||
| self.handle_user_logout() | ||
| if self.environ.get("is_api_request", False): |
Member
There was a problem hiding this comment.
I think a test case for the API auth case may be missing?
Contributor
Author
There was a problem hiding this comment.
no worries, I've added unit tests for API requests
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to ensure users have a current, valid access token from the OIDC provider, so when attempting to refresh (due to access token expiry), log the user out and redirect to OIDC login. This is gated behind an
oidc_require_refreshconfig flag.How to test the changes?
(Select all options that apply)
License