[25.1] Use correct timezone to compare step scheduling#22446
Open
mvdbeek wants to merge 1 commit intogalaxyproject:release_25.1from
Open
[25.1] Use correct timezone to compare step scheduling#22446mvdbeek wants to merge 1 commit intogalaxyproject:release_25.1from
mvdbeek wants to merge 1 commit intogalaxyproject:release_25.1from
Conversation
0b840d4 to
b3f5f6d
Compare
Member
|
See also #18460 |
`get_last_workflow_invocation_step_update_time()` returns UTC time (it's set by galaxy.model.orm.now.now()) while datetime.now() is your local time. If your system is not on UTC time this caused 5 minute scheduling delays for steps depending on expression tools that only produce parameters. Fixes the delay observed in galaxyproject/tools-iuc#7314
b3f5f6d to
5962ba2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_last_workflow_invocation_step_update_time()returns UTC time (it's set by galaxy.model.orm.now.now()) while datetime.now() is your local time.If your system is not on UTC time this caused 5 minute scheduling delays for steps depending on expression tools that only produce parameters.
Fixes the delay observed in galaxyproject/tools-iuc#7314
How to test the changes?
(Select all options that apply)
License