Skip to content

[25.1] Use correct timezone to compare step scheduling#22446

Open
mvdbeek wants to merge 1 commit intogalaxyproject:release_25.1from
mvdbeek:fix-scheduling-delay
Open

[25.1] Use correct timezone to compare step scheduling#22446
mvdbeek wants to merge 1 commit intogalaxyproject:release_25.1from
mvdbeek:fix-scheduling-delay

Conversation

@mvdbeek
Copy link
Copy Markdown
Member

@mvdbeek mvdbeek commented Apr 9, 2026

get_last_workflow_invocation_step_update_time() returns UTC time (it's set by galaxy.model.orm.now.now()) while datetime.now() is your local time.

If your system is not on UTC time this caused 5 minute scheduling delays for steps depending on expression tools that only produce parameters.

Fixes the delay observed in galaxyproject/tools-iuc#7314

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@nsoranzo
Copy link
Copy Markdown
Member

nsoranzo commented Apr 9, 2026

See also #18460

@github-actions github-actions bot added this to the 26.1 milestone Apr 9, 2026
`get_last_workflow_invocation_step_update_time()` returns UTC time (it's
set by galaxy.model.orm.now.now()) while datetime.now() is your local
time.

If your system is not on UTC time this caused 5 minute scheduling delays
for steps depending on expression tools that only produce parameters.

Fixes the delay observed in galaxyproject/tools-iuc#7314
@mvdbeek mvdbeek force-pushed the fix-scheduling-delay branch from b3f5f6d to 5962ba2 Compare April 9, 2026 19:53
@mvdbeek mvdbeek requested a review from a team April 13, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Needs Review

Development

Successfully merging this pull request may close these issues.

2 participants