Draft
Conversation
mvdbeek
reviewed
Feb 3, 2026
mvdbeek
reviewed
Feb 3, 2026
| class TestWorkflowCompletionManagerHookTracking: | ||
| """Tests for WorkflowCompletionManager hook execution tracking.""" | ||
|
|
||
| def test_mark_hook_executed_records_hook_name(self): |
Member
There was a problem hiding this comment.
I'm a big fan of making sure the key points in the interface are tested, not every small detail. I am almost certain I deleted those tests from claude.
Also note that the hook execution itself is covered in selenium.
mvdbeek
reviewed
Feb 3, 2026
| @@ -0,0 +1,37 @@ | |||
| import { describe, expect, it } from "vitest"; | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds minor additional tests to increase test coverage for newly highlighted release features.
How to test the changes?
(Select all options that apply)
License